Skip to content

Correct a spelling mistake in the documatation of continuous_scale #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 27, 2019
Merged

Correct a spelling mistake in the documatation of continuous_scale #3643

merged 5 commits into from
Nov 27, 2019

Conversation

microly
Copy link
Contributor

@microly microly commented Nov 25, 2019

Correct a spelling mistake in this line:

ggplot2/R/scale-.r

Line 52 in 5dfe498

#' scales, which ways use [scales::rescale()].

It should be "scales, which always use [scales::rescale()]. ".

@yutannihilation
Copy link
Member

Thanks! Could you regenerate the documents by devtools::document()? If you don't know how to do, don't worry, we'll take care of it.

@microly
Copy link
Contributor Author

microly commented Nov 26, 2019

Thanks for your reply!
I am not familiar with regenerating the documents, but I will try it in my free time.

@microly
Copy link
Contributor Author

microly commented Nov 26, 2019

Is it ok now?
@yutannihilation

yutannihilation
yutannihilation approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you needed to resolve conflict as well, but it's fine.

@yutannihilation yutannihilation merged commit 6424808 into tidyverse:master Nov 27, 2019
@microly
Copy link
Contributor Author

microly commented Nov 27, 2019

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yutannihilation yutannihilation yutannihilation approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@microly @yutannihilation